Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parsing programs with integers that overflow a u64 will no longer panic; instead, they will raise an error. #372

Merged
merged 4 commits into from
May 28, 2024
Merged

fix: Parsing programs with integers that overflow a u64 will no longer panic; instead, they will raise an error. #372

merged 4 commits into from
May 28, 2024

Conversation

MarquessV
Copy link
Contributor

Closes #371

@MarquessV MarquessV linked an issue May 24, 2024 that may be closed by this pull request
The lexer panics when parsing integers larger than u64::MAX #371
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-28 17:28 UTC

Shadow53
Shadow53 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@Shadow53 Shadow53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm surprised we had an unwrap left in here. Should we check for others?

Left a comment with a suggestion for simplifying the error handling.

MarquessV and others added 2 commits May 28, 2024 09:35
@MarquessV @Shadow53
map
87f80e2 
Co-authored-by: Michael Bryant <mbryant@rigetti.com>
@MarquessV
rustfmt
a2255bd
@MarquessV
Copy link
Contributor Author

Looks good. I'm surprised we had an unwrap left in here. Should we check for others?

Left a comment with a suggestion for simplifying the error handling.

I ran cargo clippy -- -Wclippy::unwrap_used -Wclippy::expect_used and all remaining usages looked justified to me.

@MarquessV MarquessV closed this May 28, 2024
@MarquessV MarquessV reopened this May 28, 2024
@MarquessV MarquessV merged commit b31c207 into main May 28, 2024
29 checks passed
@MarquessV MarquessV deleted the 371-the-lexer-panics-when-parsing-integers-larger-than-u64max branch May 28, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadow53 Shadow53 Shadow53 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The lexer panics when parsing integers larger than u64::MAX
2 participants
@MarquessV @Shadow53