♻️ Update to TCA 1.2.0 syntax #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yermukhanbet
commented
Oct 25, 2023
yermukhanbet
commented
- Change ReducerProtocol to Reducer
- Add observer to ViewStateOf init
- Change PreviewProvider to macro
Comment on lines
33
to
36
| let store: StoreOf<___VARIABLE_productName:identifier___> = .init( | ||
| initialState: .init(), | ||
| reducer: { ___VARIABLE_productName:identifier___() } | ||
| ) |
There was a problem hiding this comment.
Since the global variable store is only for preview,
I think It's better to wrap in #if DEBUG
or inline in ___FILEBASENAMEASIDENTIFIER___(store: ....)
There was a problem hiding this comment.
Since some might not use #if DEBUG flags, moved init to inline:
ef4285
korJAEYOUNGYUN
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.