Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with axios custom instance #5

Closed
wuelcas opened this issue Apr 26, 2018 · 2 comments
Closed

Doesn't work with axios custom instance #5

wuelcas opened this issue Apr 26, 2018 · 2 comments

Comments

@wuelcas
Copy link
Contributor

wuelcas commented Apr 26, 2018 •
edited
Loading

I made an axios custom instance and the progress bar doesn't disappear when the request ends. Looking at the source code, you are not handling custom instance, just the normal axios instance.
@wuelcas wuelcas mentioned this issue Apr 26, 2018
Merged
@rikmms
Copy link
Owner

rikmms commented Apr 27, 2018

New version [1.2.0] published on NPM with this new feature.

@rikmms rikmms closed this as completed Apr 27, 2018
@prpateldev
Copy link

I am getting error in a react typescript project
my packages are
"axios": "^0.19.0",
"axios-progress-bar": "^1.2.0",

ERROR in /Users/jasmine/jas/work/node_modules/axios-progress-bar/dist/index.js
Module not found: Error: Can't resolve 'axios' in '/Users/jasmine/jas/work/node_modules/axios-progress-bar/dist'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rikmms @wuelcas @prpateldev