Make it work with a custom instance #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also can you let me know when this is going to be live in npm? I'm currently working on an application using this package and it would be very helpful if this change (if it's merged) it's live to use it. Thanks. |
|
Hi @wuelcas Thanks for the improvement. Good work! |
|
New version [1.2.0] published on NPM ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #5
Now an axios custom instance can be pass to the function as a param. I put it as the second param to not affect current applications that are maybe using the nprogress config.
My suggestion is that the function should receive one single param which would be an object containing the custom instance and the nprogress config.