Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: remove input limit #863

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fuzz: remove input limit #863

merged 1 commit into from
Sep 18, 2023

Conversation

manunio
Copy link
Contributor

@manunio manunio commented Sep 18, 2023

While working on https://github.com/djc/askama/pull/862 fuzz_parser was crashing and failing oss-fuzz build_checks. so a limit of 500 was placed, this pr removes that.

While working on https://github.com/djc/askama/pull/862 fuzz_parser was
crashing and failing oss-fuzz build_checks. so a limit of 500 was placed, this pr removes that.
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there some work elsewhere done to enable this limit removal?

@djc djc merged commit 2ef2b9d into rinja-rs:main Sep 18, 2023
18 checks passed
@manunio
Copy link
Contributor Author

manunio commented Sep 18, 2023

Was there some work elsewhere done to enable this limit removal?

Sorry i didn't get you.

While working on https://github.com/djc/askama/pull/862 fuzz_parser was crashing and failing oss-fuzz build_checks. so a limit of 500 was placed, this pr removes that.

I meant that build check were failing locally while i was was working on integrating this project on oss-fuzz. Did you mean that?

@manunio manunio deleted the fuzz-remove-limit branch September 18, 2023 14:11
@djc
Copy link
Collaborator

djc commented Sep 18, 2023

I'm confused why the fuzzer is not causing stack overflows anymore, as you said it did while initially integrating (in #862).

@manunio
Copy link
Contributor Author

manunio commented Sep 18, 2023

I'm confused why the fuzzer is not causing stack overflows anymore, as you said it did while initially integrating (in #862).

I just tested locally with rev 2ef2b9d it is causing stack overflow. May be you were testing it with 8f3140a as it contains input limit (which helps to avoid stack overflow).

@djc
Copy link
Collaborator

djc commented Sep 18, 2023

I'm confused. Why are you proposing to remove the limit if doing so causes stack overflows?

@manunio
Copy link
Contributor Author

manunio commented Sep 18, 2023

I'm confused. Why are you proposing to remove the limit if doing so causes stack overflows?bugs

Sorry about confusion, I assumed that you are interested in stack overflow report, as you mentioned in my previous pr https://github.com/djc/askama/pull/862#discussion_r1324461206. If you are not interested in such reports, we can revert this pr and place the limit back :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants