ci: fix a few typos and add check #160
Conversation
|
A bug in https://github.com/crate-ci/typos lets the program run forever. Investigating. |
| fo = "fo" | ||
| Fo = "Fo" |
There was a problem hiding this comment.
I never saw these two as fillers.
There was a problem hiding this comment.
Hm, yes, "fo", "Fo" & "Ba" are actually not used in filler texts, but "foO", "FoO", "BaR", in casing tests. Will change the comment.
| @@ -54,7 +54,7 @@ Hello | |||
| To be noted, if one of the trimmed characters is a newline, then the only | |||
| character remaining will be a newline. | |||
|
|
|||
| If you want this to be the default behaviour, you can set `whitespace` to | |||
| If you want this to be the default behavior, you can set `whitespace` to | |||
There was a problem hiding this comment.
This is british english (left) vs US english (right). Both are valid.
There was a problem hiding this comment.
Yes, but IMHO we should stick to one locale.
I guess in a French text you would probably replace "nonante", too, even if it is valid Belgian French; as I would probably replace instances of "Jänner" ("January", Swiss) or "heuer" ("this current year", Austrian). :)
There was a problem hiding this comment.
Nah I prefer nonante, makes much more sense. Although I'm surprised by how many people know about this compared to how many people living in France know about it. 🤣
rinja/benches/escape.rs
Outdated
| @@ -13,7 +13,7 @@ fn escaping(b: &mut criterion::Bencher<'_>) { | |||
| Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris consequat tellus sit | |||
| amet ornare fermentum. Etiam nec erat ante. In at metus a orci mollis scelerisque. | |||
| Sed eget ultrices turpis, at sollicitudin erat. Integer hendrerit nec magna quis | |||
| venenatis. Vivamus non dolor hendrerit, vulputate velit sed, varius nunc. Quisque | |||
| venenatis. Vivamus non dolor hendrerit, vulputate velit sed, various nunc. Quisque | |||
There was a problem hiding this comment.
Are we fixing latin too? XD
There was a problem hiding this comment.
Yea, in all other cases "various" would be right. I hope Cicero wouldn't mind that I changed his text. :)
There was a problem hiding this comment.
Wouldn't it be better in this case to move this text out of source code?
There was a problem hiding this comment.
Probably. It's used in two places anyway.
This PR adds `_typos.toml`, which lets `typos` ignore generated data. Some filler texts are "fixed", too. It does not matter what the actual text is.
I blacklisted the fuzzed files. Reported upstream: crate-ci/typos#1088. |
|
Looks good! I'm quite happy that moving the lorem ipsum out of the code allowed to remove a duplicate. Unexpected benefits. :D |
This PR adds
_typos.toml, which letstyposignore generated data.Some filler texts are "fixed", too. It does not matter what the actual text is.Resolves #70.