Improve config delimiters characters check #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
config-delimiters
branch
2 times, most recently
from
52a55d3 to
fb089fe
Compare
GuillaumeGomez
commented
Sep 19, 2024
| "> and <+b+>" | ||
| --> tests/ui/broken-config.rs:20:21 | ||
| | | ||
| 20 | #[template(source = "<+a+> and <+b+>", config = "operator-plus-config.toml", syntax = "plus", ext = "txt")] |
There was a problem hiding this comment.
So in here, the template is perfectly valid but doesn't work. Not sure how to fix that...
Kijewski
requested changes
Oct 8, 2024
GuillaumeGomez
force-pushed
the
config-delimiters
branch
2 times, most recently
from
25cecd0 to
daa93c2
Compare
|
Finally had some time to update this. I added the missing operators, thanks for the suggestion! |
Kijewski
reviewed
Oct 15, 2024
rinja_parser/src/lib.rs
Outdated
| @@ -824,6 +824,15 @@ impl<'a> SyntaxBuilder<'a> { | |||
| "delimiters may not contain white spaces. \ | |||
| The {k} delimiter ({s:?}) contains white spaces", | |||
| )); | |||
| } else if is_closing | |||
| && ['(', ')', '-', '+', '~', '.', '>', '<', '&', '|', '!'] | |||
There was a problem hiding this comment.
Actually, ) should be fine. We only ever look for ) in conjunction with a (. This way, if someone wants to use e.g. (( expr )) it would still work fine. Sorry that I didn't notice that during my first review!
GuillaumeGomez
force-pushed
the
config-delimiters
branch
from
daa93c2 to
c77cd37
Compare
|
Updated. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally I have something before the next release. :)