Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify trait impl for reference wrapper types #200

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Unify trait impl for reference wrapper types #200

merged 3 commits into from
Oct 23, 2024

Conversation

Kijewski
Copy link
Collaborator

This changes makes sure that no implementation is forgotten and deduplicates some code.

@Kijewski
Unify trait impl for reference wrapper types
f7d1e9a 
This changes makes sure that no implementation is forgotten and
deduplicates some code.
@Kijewski Kijewski marked this pull request as ready for review October 16, 2024 19:49
GuillaumeGomez
GuillaumeGomez previously approved these changes Oct 20, 2024
View reviewed changes
@GuillaumeGomez
Copy link
Contributor

Looks good to me, thanks! Feel free to merge.

@Kijewski
Copy link
Collaborator Author

I added better implementations for impl<T> X for Pin<T>. I couldn't get it to work in the macro, so I re-introduced some repetition. :|

@GuillaumeGomez
Copy link
Contributor

It's fine. Still better than before. :)

@GuillaumeGomez GuillaumeGomez merged commit 1e319fd into rinja-rs:master Oct 23, 2024
34 checks passed
@Kijewski Kijewski deleted the pr-ref branch October 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kijewski @GuillaumeGomez