-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enum from/to string explicit mappings #1483
Enum from/to string explicit mappings #1483
Conversation
Marked as a breaking change as the type of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution, I added my feedback 😊
test/Riok.Mapperly.Tests/Mapping/StringToEnumExplicitMapTest.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToStringMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/StringToEnumMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToEnumMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToStringMappingBuilder.cs
Outdated
Show resolved
Hide resolved
7fb6fe5
to
d4fab21
Compare
d4fab21
to
e49ab78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these fast updates!
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToEnumMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToStringMappingBuilder.cs
Outdated
Show resolved
Hide resolved
test/Riok.Mapperly.Tests/Mapping/StringToEnumExplicitMapTest.cs
Outdated
Show resolved
Hide resolved
Sorry for the delay, I was busy with work. Additionally, I still couldn't get the documentation fix to run on my Mac (yarn lint + yarn fix), so the pipeline step might still be failing. |
No need to apologise! Thank you for this great contribution 🥳 I'm already looking forward to #1486 😊 |
Enum from/to string explicit mappings
Description
Added support for enum from/to string explicit mappings using MapEnumValueAttribute
Fixes #1476
Checklist