Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint dependency problems #11

Merged
merged 1 commit into from
May 27, 2022
Merged

fix: eslint dependency problems #11

merged 1 commit into from
May 27, 2022

Conversation

BeeMargarida
Copy link
Contributor

- -
Issue Similar to ripe-tech/ripe-components-vue#596
Dependencies
Decisions - Port eslint-config-hive dependencies
- Lock eslint-plugin-mocha to 10.0.3 due to problem with mocha and ramda packages
Animated GIF --

@BeeMargarida BeeMargarida added bug Something isn't working back-port 🔮 Requires back-porting of functionality to other projects no-changelog No CHANGELOG update is required labels May 26, 2022
@BeeMargarida BeeMargarida requested a review from joamag May 26, 2022 14:57
@ripe-tobias-bot
Copy link

Woof, Woof!

Thank you @BeeMargarida for submitting the "fix: eslint dependency problems" pull request 😎.

Please do not forget to review our internal guidelines:

  • Review the code in the PR using a peer 🧑‍🤝‍🧑
  • Make sure all the linting process has been executed an passed 👌
  • Make sure unit tests are passing ✅
  • Ensure that proper code standards are met 📋
  • Fill in the PR's summary (issue, dependencies, decisions and GIF)
  • Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@ripe-tobias-bot
Copy link

Woof, Woof!

Oops! @BeeMargarida you may have to fix some errors:

  • Please specify a link to the issue or rationale in the description of the PR ❗️

Please address these issues to continue with the Pull Request merge process.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@ripe-tobias-bot ripe-tobias-bot bot assigned BeeMargarida and unassigned joamag May 26, 2022
@BeeMargarida BeeMargarida assigned joamag and unassigned BeeMargarida May 26, 2022
@joamag joamag merged commit 915b2a7 into master May 27, 2022
@joamag joamag deleted the ms/fix-eslint-problems branch May 27, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-port 🔮 Requires back-porting of functionality to other projects bug Something isn't working no-changelog No CHANGELOG update is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants