Storybook route #35
Storybook route #35
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/platforme/ripe-sdk-components-vue/id0sozyr0 |
gcandal
added
the
back-port 🔮
|
Will need porting to https://github.com/ripe-tech/ripe-sdk-components-react as well |
webpack.config.js
Outdated
| } | ||
| }, | ||
| useBuiltIns: "entry", | ||
| corejs: "3" | ||
| } | ||
| ] | ||
| : "@babel/preset-env" | ||
| : [ | ||
| "@babel/preset-env", | ||
| { | ||
| useBuiltIns: "entry", | ||
| corejs: "3" | ||
| } | ||
| ] | ||
| ], | ||
| plugins: [ | ||
| [ | ||
| "@babel/plugin-transform-runtime", | ||
| { | ||
| regenerator: true | ||
| } | ||
| ] |
There was a problem hiding this comment.
On which of our products is this based on?
There was a problem hiding this comment.
uxf_webpack, which is being used by ripe-components-vue.
I included here because it was necessary to solve the regeneratorRuntime error that was being thrown by the styleguide
There was a problem hiding this comment.
It should be part of the host application then. In this case, that would be storybook
webpack.config.js
Outdated
| } | ||
| }, | ||
| useBuiltIns: "entry", | ||
| corejs: "3" | ||
| } | ||
| ] | ||
| : "@babel/preset-env" | ||
| : [ | ||
| "@babel/preset-env", | ||
| { | ||
| useBuiltIns: "entry", | ||
| corejs: "3" | ||
| } | ||
| ] | ||
| ], | ||
| plugins: [ | ||
| [ | ||
| "@babel/plugin-transform-runtime", | ||
| { | ||
| regenerator: true | ||
| } | ||
| ] |
There was a problem hiding this comment.
It should be part of the host application then. In this case, that would be storybook
|
@gcandal The problem is that this is required by the styleguide, not storybook. The styleguide is using the webpack config file. However, I can change it so that this is moved to the webpack cconfiguration in the styleguide.config.js file. |
Oh you're right. Yep, go for it :). The whole point is to let the host application include the regenerator runtime. If all libraries included it, you could end up with 100s of duplicates. |
gcandal
removed
the
back-port 🔮
Related to the
iframe.htmlloading.Also problem with the documentation, missing regeneratorRuntime.
-storybook-eol/storybook-deployer#56
-vercel/serve#631
-storybookjs/storybook#12814
-storybookjs/storybook#11694
- Added
@babel/plugin-transform-runtimeto fixregeneratorRuntimeerror in styleguidist documentation./storybook. If the link to the storybook is clicked in the styleguide, the storybook it is redirected to is the one in master, which is broken.