Show stack traces for uncaught exceptions in middlewares (RLJS-277)

- Return 400 error for client errors in Balances, Trustlines, Payments,
  and Orders.
- Silence api/logger.js during tests. The server/logger.js still
  logs unhandled exceptions during tests.
- Includes some lint error fixes

api/balances.js

@@ -33,7 +33,10 @@ function getBalances(account, options, callback) {
   if (validate.fail([
     validate.account(account),
     validate.currency(options.currency, true),
-    validate.counterparty(options.counterparty, true)
+    validate.counterparty(options.counterparty, true),
+    validate.ledger(options.ledger, true),
+    validate.limit(options.limit, true),
+    validate.paging(options,true)
   ], callback)) {
     return;
   }

api/lib/errors.js

@@ -1,13 +1,24 @@
 /* eslint-disable valid-jsdoc */
 'use strict';
+
+/**
+ * Base class for all errors
+ */
+function RippleError(message) {
+  this.message = message;
+}
+RippleError.prototype = new Error;
+RippleError.prototype.name = 'RippleError';
+
+
 /**
  * Invalid Request Error
  * Missing parameters or invalid parameters
  */
 function InvalidRequestError(message) {
   this.message = message;
 }
-InvalidRequestError.prototype = new Error();
+InvalidRequestError.prototype = new RippleError;
 InvalidRequestError.prototype.name = 'InvalidRequestError';
 InvalidRequestError.prototype.error = 'restINVALID_PARAMETER';
 
@@ -18,7 +29,7 @@ InvalidRequestError.prototype.error = 'restINVALID_PARAMETER';
 function NetworkError(message) {
   this.message = message;
 }
-NetworkError.prototype = new Error();
+NetworkError.prototype = new RippleError;
 NetworkError.prototype.name = 'NetworkError';
 
 /**
@@ -38,7 +49,7 @@ RippledNetworkError.prototype.error = 'restRIPPLED_NETWORK_ERR';
 function TransactionError(message) {
   this.message = message;
 }
-TransactionError.prototype = new Error();
+TransactionError.prototype = new RippleError;
 TransactionError.prototype.name = 'TransactionError';
 
 /**
@@ -48,7 +59,7 @@ TransactionError.prototype.name = 'TransactionError';
 function NotFoundError(message) {
   this.message = message;
 }
-NotFoundError.prototype = new Error();
+NotFoundError.prototype = new RippleError;
 NotFoundError.prototype.name = 'NotFoundError';
 NotFoundError.prototype.error = 'restNOT_FOUND';
 
@@ -59,7 +70,7 @@ NotFoundError.prototype.error = 'restNOT_FOUND';
 function TimeOutError(message) {
   this.message = message;
 }
-TimeOutError.prototype = new Error();
+TimeOutError.prototype = new RippleError;
 TimeOutError.prototype.name = 'TimeOutError';
 
 /**
@@ -69,7 +80,7 @@ TimeOutError.prototype.name = 'TimeOutError';
 function ApiError(message) {
   this.message = message;
 }
-ApiError.prototype = new Error();
+ApiError.prototype = new RippleError;
 ApiError.prototype.name = 'ApiError';
 
 /**
@@ -89,7 +100,7 @@ DuplicateTransactionError.prototype.error = 'restDUPLICATE_TRANSACTION';
 function DatabaseError(message) {
   this.message = message;
 }
-DatabaseError.prototype = new Error();
+DatabaseError.prototype = new RippleError;
 DatabaseError.prototype.name = 'DatabaseError';
 
 module.exports = {
@@ -101,5 +112,6 @@ module.exports = {
   TimeOutError: TimeOutError,
   ApiError: ApiError,
   DuplicateTransactionError: DuplicateTransactionError,
-  DatabaseError: DatabaseError
+  DatabaseError: DatabaseError,
+  RippleError: RippleError
 };

api/lib/utils.js

@@ -2,6 +2,7 @@
 'use strict';
 var bignum = require('bignumber.js');
 var validator = require('./schema-validator.js');
+var ripple = require('ripple-lib');
 
 function dropsToXrp(drops) {
   return bignum(drops).dividedBy(1000000.0).toString();
@@ -94,7 +95,22 @@ function compareTransactions(first, second) {
   return first.ledger_index < second.ledger_index ? -1 : 1;
 }
 
+function isValidLedgerSequence(ledger) {
+  return (Number(ledger) >= 0) && isFinite(Number(ledger));
+}
+
+function isValidLedgerHash(ledger) {
+  return ripple.UInt256.is_valid(ledger);
+}
+
+function isValidLedgerWord(ledger) {
+  return (/^current$|^closed$|^validated$/.test(ledger));
+}
+
 module.exports = {
+  isValidLedgerSequence: isValidLedgerSequence,
+  isValidLedgerWord: isValidLedgerWord,
+  isValidLedgerHash: isValidLedgerHash,
   dropsToXrp: dropsToXrp,
   xrpToDrops: xrpToDrops,
   parseLedger: parseLedger,
@@ -103,3 +119,4 @@ module.exports = {
   txFromRestAmount: txFromRestAmount,
   compareTransactions: compareTransactions
 };
+

api/lib/validate.js

@@ -3,6 +3,7 @@ var _ = require('lodash');
 var errors = require('./errors.js');
 var validator = require('./schema-validator');
 var ripple = require('ripple-lib');
+var utils = require('./utils');
 
 function addOptionalOption(validatorFunction) {
   return function(parameter, optional) {
@@ -44,6 +45,41 @@ function validateIssue(issue) {
   ]) || null;
 }
 
+
+function validateLedger(ledger) {
+  if (!(utils.isValidLedgerSequence(ledger)
+        || utils.isValidLedgerHash(ledger)
+        || utils.isValidLedgerWord(ledger)))
+  {
+    return new errors.InvalidRequestError(
+      'Invalid or Missing Parameter: ledger');
+  }
+
+  return null;
+}
+
+function validatePaging(options) {
+  if (options.marker) {
+    if (!options.ledger ||
+        !(utils.isValidLedgerSequence(options.ledger
+          || utils.isValidLedgerHash(options.ledger))))
+      {
+      return new errors.InvalidRequestError(
+        'Invalid or Missing Parameter: ledger');
+    }
+  }
+  return null;
+}
+
+function validateLimit(limit) {
+  if (!(limit === 'all' || !_.isNaN(Number(limit)))) {
+    return new errors.InvalidRequestError(
+      'Invalid or Missing Parameter: limit');
+  }
+  return null;
+}
+
+
 function fail(results, callback) {
   var error = _.find(results);
   if (error) {
@@ -53,8 +89,13 @@ function fail(results, callback) {
   return false;
 }
 
-module.exports.account = addOptionalOption(validateAccount);
-module.exports.currency = addOptionalOption(validateCurrency);
-module.exports.counterparty = addOptionalOption(validateCounterparty);
-module.exports.issue = addOptionalOption(validateIssue);
-module.exports.fail = fail;
+module.exports = {
+  account: addOptionalOption(validateAccount),
+  currency: addOptionalOption(validateCurrency),
+  counterparty: addOptionalOption(validateCounterparty),
+  issue: addOptionalOption(validateIssue),
+  ledger: addOptionalOption(validateLedger),
+  limit: addOptionalOption(validateLimit),
+  paging: addOptionalOption(validatePaging),
+  fail: fail
+};

api/orders.js

@@ -11,6 +11,7 @@ var errors = require('./lib/errors.js');
 var TxToRestConverter = require('./lib/tx-to-rest-converter.js');
 var validator = require('./lib/schema-validator.js');
 var bignum = require('bignumber.js');
+var validate = require('./lib/validate');
 
 var InvalidRequestError = errors.InvalidRequestError;
 
@@ -42,13 +43,13 @@ var DefaultPageLimit = 200;
 function getOrders(account, options, callback) {
   var self = this;
 
-  function validateOptions() {
-    if (!ripple.UInt160.is_valid(account)) {
-      return Promise.reject(new InvalidRequestError(
-        'Parameter is not a valid Ripple address: account'));
-    }
-
-    return Promise.resolve();
+  if (validate.fail([
+    validate.account(account),
+    validate.ledger(options.ledger, true),
+    validate.limit(options.limit, true),
+    validate.paging(options,true)
+  ], callback)) {
+    return;
   }
 
   function getAccountOrders(prevResult) {
@@ -132,10 +133,10 @@ function getOrders(account, options, callback) {
 
     return promise;
   }
-  validateOptions(options)
-  .then(getAccountOrders)
-  .then(respondWithOrders)
-  .catch(callback);
+
+  getAccountOrders()
+    .then(respondWithOrders)
+    .catch(callback);
 }
 
 /**

api/payments.js

@@ -11,11 +11,13 @@ var utils = require('./lib/utils');
 var RestToTxConverter = require('./lib/rest-to-tx-converter.js');
 var TxToRestConverter = require('./lib/tx-to-rest-converter.js');
 var SubmitTransactionHooks = require('./lib/submit_transaction_hooks.js');
-var errors = require('./lib/errors.js');
 
-var InvalidRequestError = errors.InvalidRequestError;
-var NotFoundError = errors.NotFoundError;
-var TimeOutError = errors.TimeOutError;
+var errors = require('./lib/errors');
+var InvalidRequestError     = errors.InvalidRequestError;
+var NetworkError            = errors.NetworkError;
+var NotFoundError           = errors.NotFoundError;
+var TimeOutError            = errors.TimeOutError;
+var ApiError                = errors.ApiError;
 
 var DEFAULT_RESULTS_PER_PAGE = 10;
 

api/trustlines.js

@@ -46,7 +46,10 @@ function getTrustLines(account, options, callback) {
   if (validate.fail([
     validate.account(account),
     validate.currency(options.currency, true),
-    validate.counterparty(options.counterparty, true)
+    validate.counterparty(options.counterparty, true),
+    validate.ledger(options.ledger, true),
+    validate.limit(options.limit, true),
+    validate.paging(options)
   ], callback)) {
     return;
   }

server/error-handler.js

@@ -11,8 +11,14 @@ var NotFoundError = errors.NotFoundError;
 var TimeOutError = errors.TimeOutError;
 var ApiError = errors.ApiError;
 var DatabaseError = errors.DatabaseError;
+var RippleError = errors.RippleError;
+var RippleLibError = require('ripple-lib').RippleError;
 
 
+function isRippleError(error) {
+  return error instanceof RippleError || error instanceof RippleLibError;
+}
+
 function handleError(error, req, res, next) {
   // If in debug mode, print errors
   if (config.get('debug')) {
@@ -23,6 +29,9 @@ function handleError(error, req, res, next) {
     } else {
       logger.error(error);
     }
+  } else if (!isRippleError(error)) {
+    // always log stack traces for uncaught exceptions
+    error.stack && logger.error(error.stack);
   }
 
   var err_obj = {

server/logger.js

@@ -5,24 +5,15 @@ var config = require('./config');
 var morgan = require('morgan');
 var version = require('./version');
 
-
 var logger = exports.logger = new winston.Logger({
   transports: [
     new winston.transports.Console({
       prettyPrint: true,
       colorize: true,
-      handleExceptions: false,
-      level: 'info',
+      handleExceptions: true,
+      level: config.get('NODE_ENV') === 'test' ? 'error' : 'info',
       showLevel: true,
       timestamp: true,
-      silent: config.get('NODE_ENV') === 'test'
-    })
-  ],
-  exceptionHandlers: [
-    new winston.transports.Console({
-      prettyPrint: true,
-      colorize: true,
-      timestamp: true
     })
   ],
   exitOnError: true