This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
[BUG] Orders: Correct mishandling XRP amounts and use 'counterparty' (RLJS-172)(RLJS-174) #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +82,7 @@ suite('get orders', function() { | |||
| .end(function(err, res) { | |||
| if (err) return done(err); | |||
|
|
|||
| assert.strictEqual(res.body.orders.length, 34); | |||
| assert.strictEqual(res.body.orders.length, 36); | |||
There was a problem hiding this comment.
This went up by 2 because XRP orders show up on every page I think
There was a problem hiding this comment.
Pretty sure it's because of these lines
{
"flags": 0,
"seq": 844069,
"taker_gets": {
"currency": "USD",
"issuer": "rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B",
"value": "40"
},
"taker_pays": "1000000"
}
- Adds utils.parseCurrencyAmount() (RLJS-172)(RLJS-174)
alandotcom
force-pushed
the
bug/orders_counterparty
branch
from
399a001 to
a79f7c3
Compare
|
Updated with |
|
LGTM |
1 similar comment
|
LGTM |
|
Can we merge? |
wltsmrz
added a commit
that referenced
this pull request
Jan 6, 2015
[BUG] Orders: Correct mishandling XRP amounts and use 'counterparty' (RLJS-172)(RLJS-174)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(RLJS-172)(RLJS-174)