This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
[FIX] Correctly determine when to set SendMax (RLJS-272) #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original tx_json:
{ Flags: 0,
InvoiceID: '7788EE2DCFDF27FAB1D67289A121DB21BF16117BF298B38B572CF5FC6DC4DDC4',
TransactionType: 'Payment',
Account: 'ACCOUNT1',
Amount:
{ value: '0.0003272934271954',
currency: 'GWD',
issuer: 'ACCOUNT2' },
Destination: 'ACCOUNT2',
DestinationTag: 74,
SendMax:
{ value: '0.0003272934271954',
currency: 'GWD',
issuer: 'ACCOUNT1' } } |
* release: Bump package version
* release: Bump version to 1.6.0-rc3 [FIX] Payment state is pending until validated (RLJS-318)
Plenty of nice changes since 0.7 Highlights: - Correctly log Error objects: winstonjs/winston@ad2d5e1 - Logging objects to file causes slowdown (we don't log to file in this project) winstonjs/winston@5c4bd41 - Better logging of unhandled exceptions winstonjs/winston#84
Update Winston to 1.0.0
Correct 0.0.1 version number in config doc
Prepare/sign/submit flow for settings
Clean up callbacks
| }); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| test('convert() -- payment with same currency for source and destination, no issuer for source amount', function(done) { |
There was a problem hiding this comment.
Need to add a test for payment with same currency for source and destination, source amount issuer is source account, no issuer for destination amount
- SendMax should not be set when the source and destination currencies
are the same and the issuers are "any that the source is able to use
and the destination is able to receive"
e.g.,
source_amount: {
value: '0.0003272934271954',
currency: 'GWD',
issuer: ''
},
destination_amount: {
value: '0.0003272934271954',
currency: 'GWD',
issuer: 'r4p4gZaWSq8Cs1d8mn1jaGqVU1HUns1ek3'
}
- SendMax documentation:
https://ripple.com/build/transactions/#special-issuer-values-for-sendmax-and-amount
alandotcom
force-pushed
the
hotfix/sendmax
branch
from
fcabe69 to
ed96a1b
Compare
|
Ugh, rebased against develop |
|
Moved to #345 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SendMax should not be set when the source and destination currencies
are the same and the issuers are "any that the source is able to use
and the destination is able to receive"
e.g.,
(The blank issuer is automatically filled in by REST with
ACCOUNT1)source_amountin ripple-rest is used to fill in the optionalSendMaxin rippledhttps://ripple.com/build/transactions/#special-issuer-values-for-sendmax-and-amount