Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #1266

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update README #1266

wants to merge 2 commits into from

Conversation

dANW34V3R
Copy link

This pull request addresses the issue raised in #1196 by adding a section to the README

Addresses issue riscv-collab#1196 

Signed-off-by: Dan Weaver <31134699+dANW34V3R@users.noreply.github.com>
Signed-off-by: Dan Weaver <31134699+dANW34V3R@users.noreply.github.com>
@TommyMurphyTM1234
Copy link
Collaborator

I don't undertstand why the recommendation is as follows:

It is recommended to do clean builds to avoid problems with outdated stamp
files. This can be done with the following commands where $RISCV is the
install path used by the previous build:

   rm -r $RISCV
   git clean -fXd

rather than simply

make distclean

or maybe

make distclean
rm -rf <configure--prefix-dir>

@dANW34V3R
Copy link
Author

I simply took the recommendation from stefanct. Happy for it to be either way round as long as it it documented somewhere visible

@TommyMurphyTM1234
Copy link
Collaborator

I simply took the recommendation from stefanct. Happy for it to be either way round as long as it it documented somewhere visible

Seems to me that something based on make distclean would be more appropriate than manually deleting stuff (other than the actual --prefix directory which presumably needs to be manually deleted?)? In any case, I don't see that your suggested approach deletes the stamps files which I thought was key? I think that the correct way(s?) to do a "clean" need clarification and maybe explanation as the situation doesn't seem clear to me.

@dANW34V3R
Copy link
Author

I think that the correct way(s?) to do a "clean" need clarification and maybe explanation as the situation doesn't seem clear to me.

I agree, it is not clear to me either as per #1196 giving multiple, different suggestions. This should be resolved ASAP however as it can cause unclear build issues as seen in #1240, who is best to consult?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants