Skip to content
This repository has been archived by the owner on May 19, 2022. It is now read-only.

Fix absolute paths #32

Merged
merged 1 commit into from
May 23, 2021
Merged

Fix absolute paths #32

merged 1 commit into from
May 23, 2021

Conversation

kdziamura
Copy link
Contributor

Close #31

'@dir2': path.join(appPath, './src/dir2'),
'$dir3': path.join(appPath, './src/dir3'),
'my-package': path.join(appPath, './node_modules/some-package'),
'@material-ui': path.join(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I think it's better to use snapshot testing here

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I think it's better to use snapshot testing here

Good idea, I'll try it soon

@risen228
Copy link
Owner

risen228 commented May 23, 2021

@wontem Your PR is merged, but I'll release it later, after some tests (xd, miss-click)

@risen228 risen228 closed this May 23, 2021
@risen228 risen228 reopened this May 23, 2021
@risen228 risen228 merged commit 57463ea into risen228:master May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error if paths are already absolute
2 participants