remove jackson-core and other libs

libs/arrow-spi/build.gradle

@@ -22,10 +22,7 @@ dependencies {
 
   runtimeOnly "com.google.flatbuffers:flatbuffers-java:${versions.flatbuffers}"
   implementation "org.slf4j:slf4j-api:${versions.slf4j}"
-  implementation "com.fasterxml.jackson.core:jackson-core:${versions.jackson}"
-  implementation "com.fasterxml.jackson.core:jackson-databind:${versions.jackson}"
-  implementation "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:${versions.jackson}"
-  implementation "com.fasterxml.jackson.datatype:jackson-datatype-jsr310:${versions.jackson}"
+  runtimeOnly "com.fasterxml.jackson.core:jackson-databind:${versions.jackson}"
   api "com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}"
 
   implementation "commons-codec:commons-codec:${versions.commonscodec}"
@@ -45,29 +42,6 @@ tasks.named('thirdPartyAudit').configure {
     'org.slf4j.impl.StaticLoggerBinder',
     'org.slf4j.impl.StaticMDCBinder',
     'org.slf4j.impl.StaticMarkerBinder',
-    // SnakeYAML classes
-    'org.yaml.snakeyaml.DumperOptions',
-    'org.yaml.snakeyaml.DumperOptions$FlowStyle',
-    'org.yaml.snakeyaml.DumperOptions$LineBreak',
-    'org.yaml.snakeyaml.DumperOptions$ScalarStyle',
-    'org.yaml.snakeyaml.DumperOptions$Version',
-    'org.yaml.snakeyaml.LoaderOptions',
-    'org.yaml.snakeyaml.emitter.Emitter',
-    'org.yaml.snakeyaml.error.Mark',
-    'org.yaml.snakeyaml.error.MarkedYAMLException',
-    'org.yaml.snakeyaml.error.YAMLException',
-    'org.yaml.snakeyaml.events.AliasEvent',
-    'org.yaml.snakeyaml.events.CollectionStartEvent',
-    'org.yaml.snakeyaml.events.Event',
-    'org.yaml.snakeyaml.events.Event$ID',
-    'org.yaml.snakeyaml.events.ImplicitTuple',
-    'org.yaml.snakeyaml.events.MappingStartEvent',
-    'org.yaml.snakeyaml.events.NodeEvent',
-    'org.yaml.snakeyaml.events.ScalarEvent',
-    'org.yaml.snakeyaml.nodes.NodeId',
-    'org.yaml.snakeyaml.nodes.Tag',
-    'org.yaml.snakeyaml.parser.ParserImpl',
-    'org.yaml.snakeyaml.resolver.Resolver',
 
     // Reactor BlockHound
     'reactor.blockhound.BlockHound$Builder',

modules/arrow-flight-rpc/src/main/java/org/apache/arrow/flight/OpenSearchFlightClient.java

@@ -74,6 +74,7 @@
 import io.netty.handler.ssl.SslContextBuilder;
 import io.netty.handler.ssl.util.InsecureTrustManagerFactory;
 
+// TODO - add comment
 /** Client for Flight services. */
 public class OpenSearchFlightClient implements AutoCloseable {
     private static final int PENDING_REQUESTS = 5;

modules/arrow-flight-rpc/src/main/java/org/apache/arrow/flight/OpenSearchFlightServer.java

@@ -52,6 +52,7 @@
 import io.netty.handler.ssl.SslContext;
 import io.netty.handler.ssl.SslContextBuilder;
 
+// TODO - add comment
 public class OpenSearchFlightServer implements AutoCloseable {
     private static final Logger logger = LogManager.getLogger(OpenSearchFlightServer.class);
 

modules/arrow-flight-rpc/src/main/java/org/opensearch/arrow/flight/core/BaseFlightProducer.java

@@ -113,7 +113,7 @@ public void getStream(CallContext context, Ticket ticket, ServerStreamListener l
             throw e;
         } finally {
             listener.completed();
-            streamManager.removeStreamProvider(streamTicket);
+            streamManager.removeStreamProducer(streamTicket);
         }
     }
 

modules/arrow-flight-rpc/src/main/java/org/opensearch/arrow/flight/core/FlightStreamManager.java

@@ -92,11 +92,11 @@ public StreamProducerHolder getStreamProducer(StreamTicket ticket) {
     }
 
     /**
-     * Removes the stream associated with the given StreamTicket.
+     * Removes the StreamProducer with the given StreamTicket.
      *
-     * @param ticket The StreamTicket of the stream to remove.
+     * @param ticket The StreamTicket against StreamProducer to remove.
      */
-    public void removeStreamProvider(StreamTicket ticket) {
+    public void removeStreamProducer(StreamTicket ticket) {
         streamProducers.invalidate(ticket.getTicketID());
     }
 

modules/arrow-flight-rpc/src/test/java/org/opensearch/arrow/flight/core/BaseFlightProducerTests.java

@@ -180,7 +180,7 @@ public void testGetStream_SuccessfulFlow() throws Exception {
         assertEquals(3, listener.getPutNextCount());
         assertEquals(3, flushCount.get());
 
-        verify(streamManager).removeStreamProvider(any(FlightStreamTicket.class));
+        verify(streamManager).removeStreamProducer(any(FlightStreamTicket.class));
         verify(root).close();
     }
 
@@ -224,7 +224,7 @@ public void testGetStream_WithSlowClient() throws Exception {
         assertEquals(5, listener.getPutNextCount());
         assertEquals(5, flushCount.get());
 
-        verify(streamManager).removeStreamProvider(any(FlightStreamTicket.class));
+        verify(streamManager).removeStreamProducer(any(FlightStreamTicket.class));
         verify(root).close();
     }
 
@@ -268,7 +268,7 @@ public void testGetStream_WithSlowClientTimeout() throws Exception {
         assertEquals(0, listener.getPutNextCount());
         assertEquals(0, flushCount.get());
 
-        verify(streamManager).removeStreamProvider(any(FlightStreamTicket.class));
+        verify(streamManager).removeStreamProducer(any(FlightStreamTicket.class));
         verify(root).close();
     }
 
@@ -311,7 +311,7 @@ public void testGetStream_WithClientCancel() throws Exception {
         assertEquals(4, listener.getPutNextCount());
         assertEquals(4, flushCount.get());
 
-        verify(streamManager).removeStreamProvider(any(FlightStreamTicket.class));
+        verify(streamManager).removeStreamProducer(any(FlightStreamTicket.class));
         verify(root).close();
     }
 
@@ -350,7 +350,7 @@ public void testGetStream_WithUnresponsiveClient() throws Exception {
         assertEquals(0, listener.getPutNextCount());
         assertEquals(0, flushCount.get());
 
-        verify(streamManager).removeStreamProvider(any(FlightStreamTicket.class));
+        verify(streamManager).removeStreamProducer(any(FlightStreamTicket.class));
         verify(root).close();
     }
 
@@ -389,7 +389,7 @@ public void testGetStream_WithServerBackpressure() throws Exception {
         assertEquals(5, listener.getPutNextCount());
         assertEquals(5, flushCount.get());
 
-        verify(streamManager).removeStreamProvider(any(FlightStreamTicket.class));
+        verify(streamManager).removeStreamProducer(any(FlightStreamTicket.class));
         verify(root).close();
     }
 
@@ -431,7 +431,7 @@ public void testGetStream_WithServerError() throws Exception {
         assertEquals(4, listener.getPutNextCount());
         assertEquals(4, flushCount.get());
 
-        verify(streamManager).removeStreamProvider(any(FlightStreamTicket.class));
+        verify(streamManager).removeStreamProducer(any(FlightStreamTicket.class));
         verify(root).close();
     }
 
@@ -447,7 +447,7 @@ public void testGetStream_StreamNotFound() throws Exception {
         assertTrue(listener.getError().getMessage().contains("Stream not found"));
         assertEquals(0, listener.getPutNextCount());
 
-        verify(streamManager).removeStreamProvider(any(FlightStreamTicket.class));
+        verify(streamManager).removeStreamProducer(any(FlightStreamTicket.class));
     }
 
     public void testProxyStreamProviderCreationWithDifferentNodeIDs() {

server/src/main/resources/org/opensearch/bootstrap/security.policy

@@ -98,7 +98,7 @@ grant {
 
   // needed by vendored Guice
   permission java.lang.RuntimePermission "accessClassInPackage.jdk.internal.vm.annotation";
-  
+
   // checked by scripting engines, and before hacks and other issues in
   // third party code, to safeguard these against unprivileged code like scripts.
   permission org.opensearch.SpecialPermission;