fix: junit test case name sanitizer (#56)

Signed-off-by: Alex Chi <iskyzh@gmail.com>
risinglightdb · Jul 3, 2022 · 6902606 · 6902606
1 parent d42eae2
commit 6902606
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.5.4] - 2022-07-02
+
+- Remove unsupported characters from juni test name.
+
 ## [0.5.3] - 2022-06-26
 
 ### Added

diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "sqllogictest"
-version = "0.5.3"
+version = "0.5.4"
 edition = "2021"
 description = "Sqllogictest parser and runner."
 license = "MIT OR Apache-2.0"

diff --git a/src/main.rs b/src/main.rs
@@ -183,17 +183,25 @@ async fn main() -> Result<()> {
         let start = Instant::now();
 
         while let Some((file, res, mut buf)) = stream.next().await {
+            let test_case_name = file
+                .replace('/', "_")
+                .replace(' ', "_")
+                .replace('.', "_")
+                .replace('-', "_");
             let case = match res {
                 Ok(duration) => {
-                    let mut case = TestCase::new(file, TestCaseStatus::success());
+                    let mut case = TestCase::new(test_case_name, TestCaseStatus::success());
                     case.set_time(duration);
                     case
                 }
                 Err(e) => {
                     writeln!(buf, "{}\n\n{:?}", style("[FAILED]").red().bold(), e)?;
                     writeln!(buf)?;
                     failed_case.push(file.clone());
-                    TestCase::new(file, TestCaseStatus::non_success(NonSuccessKind::Failure))
+                    TestCase::new(
+                        test_case_name,
+                        TestCaseStatus::non_success(NonSuccessKind::Failure),
+                    )
                 }
             };
             test_suite.add_test_case(case);
@@ -217,9 +225,14 @@ async fn main() -> Result<()> {
 
         for file in files {
             let filename = file.to_string_lossy().to_string();
+            let test_case_name = filename
+                .replace('/', "_")
+                .replace(' ', "_")
+                .replace('.', "_")
+                .replace('-', "_");
             let case = match run_test_file(&mut std::io::stdout(), pg.clone(), &file).await {
                 Ok(duration) => {
-                    let mut case = TestCase::new(filename, TestCaseStatus::success());
+                    let mut case = TestCase::new(test_case_name, TestCaseStatus::success());
                     case.set_time(duration);
                     case
                 }
@@ -228,7 +241,7 @@ async fn main() -> Result<()> {
                     println!();
                     failed_case.push(filename.clone());
                     TestCase::new(
-                        filename,
+                        test_case_name,
                         TestCaseStatus::non_success(NonSuccessKind::Failure),
                     )
                 }