fix: hash-threshold should be compared with the number of values (#121)

risinglightdb · Dec 9, 2022 · d753e4c · d753e4c
1 parent 7e39de7
commit d753e4c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/sqllogictest/src/runner.rs b/sqllogictest/src/runner.rs
@@ -429,6 +429,10 @@ impl<D: AsyncDB> Runner<D> {
         self.validator = validator;
     }
 
+    pub fn with_hash_threshold(&mut self, hash_threshold: usize) {
+        self.hash_threshold = hash_threshold;
+    }
+
     pub async fn apply_record(&mut self, record: Record) -> RecordOutput {
         match record {
             Record::Statement { conditions, .. } if self.should_skip(&conditions) => {
@@ -504,7 +508,7 @@ impl<D: AsyncDB> Runner<D> {
                     Some(SortMode::ValueSort) => todo!("value sort"),
                 };
 
-                if self.hash_threshold > 0 && rows.len() > self.hash_threshold {
+                if self.hash_threshold > 0 && rows.len() * types.len() > self.hash_threshold {
                     let mut md5 = md5::Context::new();
                     for line in &rows {
                         for value in line {