Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system: default to bash, or make shell configurable #217

Closed
xxchan opened this issue Jun 24, 2024 · 0 comments · Fixed by #225
Closed

system: default to bash, or make shell configurable #217

xxchan opened this issue Jun 24, 2024 · 0 comments · Fixed by #225

Comments

@xxchan
Copy link
Member

xxchan commented Jun 24, 2024

In RisingWave, we use

system ok
bash -c '...'

in some places, because of the limitation of sh.

https://github.com/risingwavelabs/risingwave/blob/bb39fd0eb7ea3442ada3140566eee65ad262d4cc/e2e_test/source_inline/kafka/include_key_as.slt#L185-L187

https://github.com/risingwavelabs/risingwave/blob/bb39fd0eb7ea3442ada3140566eee65ad262d4cc/e2e_test/source_inline/kafka/shared_source.slt#L163-L173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: change sh to bash risinglightdb/sqllogictest-rs
1 participant
@xxchan