Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change sh to bash #225

Merged
merged 5 commits into from
Jul 1, 2024
Merged

feat: change sh to bash #225

merged 5 commits into from
Jul 1, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jun 30, 2024

close #217

  • no strong motivation to make it configurable yet
  • bash's extensions are useful for scripting: arrays, loops, heredoc, etc.
  • When the machine's sh is actually bash, using sh to execute will succeed without warnings. This caused a lot of trouble for me (i.e., why it works locally, but not in CI?)

Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan
Copy link
Member Author

xxchan commented Jun 30, 2024

Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan xxchan requested a review from BugenZhao June 30, 2024 12:53
xxchan added 3 commits June 30, 2024 20:54
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan xxchan merged commit fbd61ef into main Jul 1, 2024
4 checks passed
@xxchan xxchan deleted the xxchan/meaningful-whitefish branch July 1, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

system: default to bash, or make shell configurable
2 participants