Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix type in tests. #192

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix: fix type in tests. #192

merged 1 commit into from
Sep 1, 2023

Conversation

youngsofun
Copy link
Contributor

No description provided.

@youngsofun
fix: fix type in tests.
339b9ce 
Signed-off-by: Yang Xiufeng <yangxiufeng.c@gmail.com>
xxchan
xxchan approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs to be fixed, But it doesn't hurt.

@youngsofun
Copy link
Contributor Author

youngsofun commented Sep 1, 2023 •
edited
Loading

I don't think this needs to be fixed, But it doesn't hurt.

I thought these tests also serve as examples. https://github.com/risinglightdb/sqllogictest-rs/blob/main/README.md#slt-test-file-format-cookbook

@xxchan xxchan merged commit 9772a35 into risinglightdb:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngsofun @xxchan