Updated superset integration due to native support #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
jetjinser
force-pushed
the
jinser/native-superset
branch
from
b3df474
to
0826bac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Description
Since RisingWave already natively supports connecting superset with PostgreSQL driver, the
sqlalchemy-risingwavedriver is no longer needed.Therefore, the relevant parts are removed from the document and rewritten to directly configure the connection with pgsql driver.
Notes
related tracking: support native integration with superset via the postgres driver risingwave#9938.
For reviewers
Preview
https://pr-1363.d2fbku9n2b6wde.amplifyapp.com/
Key points
Maybe some wording improvements are needed...
Before merging
I have checked the doc site preview, and the updated parts look good.
I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (
CharlieSYH,emile-00, &hengm3467).