fix: use new arguments #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he `--state-store` to the meta node, also update images to v0.1.17 Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
arkbriar
force-pushed
the
fix/use-new-arguments
branch
from
04c3405 to
11f6570
Compare
lmatz
approved these changes
Mar 2, 2023
arkbriar
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 73.11% 73.13% +0.01%
==========================================
Files 52 52
Lines 5445 5434 -11
==========================================
- Hits 3981 3974 -7
+ Misses 1398 1394 -4
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Let's see if the change can pass e2e tests. If not, then maybe we should prioritize the e2e migration. |
arkbriar
added
the
mergify/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
--listen-addrand--advertise-addr, deprecate the usages of--hostand--client-addr.(Deprecate: removehostcmd line argument when starting meta node risingwave#7625, deprecate--hostand--client-addressargs in v0.1.18 risingwave#7678)--state-storeand credential envs to the meta nodes. (Deprecate: Remove system params from config file risingwave#7860)v0.1.17kubectl applyin e2e tests and READMEAfter this change, the minimum supported RisingWave version is
v0.1.17.Checklist
Refer to a related PR or issue link (optional)
fix CLOUD-988 CLOUD-989 CLOUD-990 CLOUD-991 CLOUD-992 CLOUD-899