Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
kwannoel committed Jan 9, 2023
1 parent 4b1e744 commit 41aa016
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 10 deletions.
15 changes: 9 additions & 6 deletions src/frontend/planner_test/tests/testdata/dynamic_filter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@
└─LogicalProject { exprs: [t2.v2, t2.v2] }
└─LogicalScan { table: t2, columns: [t2.v2] }
stream_error: |-
Feature is not yet implemented: stream nested-loop join
No tracking issue yet. Feel free to submit a feature request at https://github.com/risingwavelabs/risingwave/issues/new?labels=type%2Ffeature&template=feature_request.yml
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
- name: |
Output indices of Dynamic Filter
TODO: currently implemented by adding a Project, https://github.com/risingwavelabs/risingwave/issues/3419
Expand Down Expand Up @@ -80,8 +81,9 @@
└─LogicalProject { exprs: [t2.v2, t2.v2] }
└─LogicalScan { table: t2, columns: [t2.v2] }
stream_error: |-
Feature is not yet implemented: stream nested-loop join
No tracking issue yet. Feel free to submit a feature request at https://github.com/risingwavelabs/risingwave/issues/new?labels=type%2Ffeature&template=feature_request.yml
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
- name: Ensure error on output columns from inner
before:
- create_tables
Expand All @@ -93,8 +95,9 @@
└─LogicalAgg { aggs: [max(t2.v2)] }
└─LogicalScan { table: t2, columns: [t2.v2] }
stream_error: |-
Feature is not yet implemented: stream nested-loop join
No tracking issue yet. Feel free to submit a feature request at https://github.com/risingwavelabs/risingwave/issues/new?labels=type%2Ffeature&template=feature_request.yml
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
- name: Use Inner Join for equi condition
before:
- create_tables
Expand Down
4 changes: 2 additions & 2 deletions src/frontend/planner_test/tests/testdata/singleton.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
└─BatchScan { table: mv, columns: [mv.v], distribution: Single }
batch_local_plan: |
BatchLookupJoin { type: Inner, predicate: mv.v = mv.v, output: [mv.v] }
└─BatchExchange { order: [], dist: Single }
└─BatchExchange { order: [mv.v ASC], dist: Single }
└─BatchScan { table: mv, columns: [mv.v], distribution: Single }
- id: select_from_singleton_mv_join_top_n
before:
Expand All @@ -46,5 +46,5 @@
└─BatchTopN { order: "[mv.v ASC]", limit: 10, offset: 0 }
└─BatchTopN { order: "[mv.v ASC]", limit: 10, offset: 0 }
└─BatchLookupJoin { type: Inner, predicate: mv.v = mv.v, output: [mv.v, mv.v] }
└─BatchExchange { order: [], dist: Single }
└─BatchExchange { order: [mv.v ASC], dist: Single }
└─BatchScan { table: mv, columns: [mv.v], distribution: Single }
5 changes: 3 additions & 2 deletions src/frontend/planner_test/tests/testdata/subquery.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -351,5 +351,6 @@
select * from auction AS hop_1
where EXISTS (select hop_1.date_time from auction group by hop_1.date_time );
stream_error: |-
Feature is not yet implemented: stream nested-loop join
No tracking issue yet. Feel free to submit a feature request at https://github.com/risingwavelabs/risingwave/issues/new?labels=type%2Ffeature&template=feature_request.yml
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md

0 comments on commit 41aa016

Please sign in to comment.