Skip to content

Commit

Permalink
refine docs
Browse files Browse the repository at this point in the history
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
  • Loading branch information
BugenZhao committed Sep 14, 2022
1 parent 50b3d91 commit 9d9bc49
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion risedev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,6 @@ risedev:
unsafe-no-fsync: true
- use: meta-node
unsafe-disable-recovery: true
enable-committed-sst-sanity-check: true
- use: compute-node
port: 5687
exporter-port: 1222
Expand Down Expand Up @@ -430,6 +429,7 @@ risedev:
- use: compactor
- use: redis


compose:
risingwave: "ghcr.io/risingwavelabs/risingwave:latest"
prometheus: "prom/prometheus:latest"
Expand Down
3 changes: 2 additions & 1 deletion src/risedevtool/src/task/compute_node_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ impl ComputeNodeService {

if provide_compute_node.len() > 1 && !is_shared_backend {
// Using a non-shared backend with multiple compute nodes will be problematic for state
// sharing like scaling. For normal end-to-end tests, this is acceptable.
// sharing like scaling. For distributed end-to-end tests with in-memory state store,
// this is acceptable.
}

let provide_meta_node = config.provide_meta_node.as_ref().unwrap();
Expand Down
5 changes: 4 additions & 1 deletion src/storage/src/memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ mod batched_iter {

/// A utility struct for iterating over a range of keys in a locked `BTreeMap`, which will batch
/// some records to make a trade-off between the copying overhead and the times of acquiring
/// the lock. Users should handle MVCC by themselves.
/// the lock.
///
/// Therefore, it's not guaranteed that we're iterating over a consistent snapshot of the map.
/// Users should handle MVCC by themselves.
pub struct Iter<K, V> {
inner: Arc<RwLock<BTreeMap<K, V>>>,
range: (Bound<K>, Bound<K>),
Expand Down

0 comments on commit 9d9bc49

Please sign in to comment.