refactor datum from Option<ScalarImpl>
to a struct
#477
Labels
component/common
Common components, such as array, data chunk, expression.
difficulty/medium
Issues that need some knowledge of the whole system
good first issue
Good for newcomers
type/refactor
Currently, we use
Option<ScalarImpl>
in RisingWave to represent a nullable value. Using type alias forDatum
indeed caused a lot of problems for us. For example, people would easily get confused when they seeOption<Datum>
orOption<Option<ScalarImpl>>
, where the outer option means existence and the inner option means null.We should refactor
Datum
to a struct, e.g.struct Datum(pub Option<ScalarImpl>)
.Note this issue requires significant refactor work. Please contact maintainers before proceeding.
https://github.com/singularity-data/risingwave-dev/blob/7c6fb9b42846d9e0414d420e2e21df327352251a/rust/common/src/types/mod.rs#L276-L277
https://github.com/singularity-data/risingwave-dev/blob/7c6fb9b42846d9e0414d420e2e21df327352251a/rust/common/src/types/mod.rs#L303-L316
The text was updated successfully, but these errors were encountered: