-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(array): unify hash function for datum and array #6209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Codecov Report
@@ Coverage Diff @@
## main #6209 +/- ##
==========================================
- Coverage 74.25% 74.17% -0.08%
==========================================
Files 940 944 +4
Lines 151208 152247 +1039
==========================================
+ Hits 112272 112929 +657
- Misses 38936 39318 +382
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xxchan
approved these changes
Nov 4, 2022
st1page
pushed a commit
that referenced
this pull request
Nov 16, 2022
* add hash_scalar Signed-off-by: Bugen Zhao <i@bugenzhao.com> * remove hash wrapper native Signed-off-by: Bugen Zhao <i@bugenzhao.com> * remove some hash_at Signed-off-by: Bugen Zhao <i@bugenzhao.com> * fix list / struct hash Signed-off-by: Bugen Zhao <i@bugenzhao.com> * use const Signed-off-by: Bugen Zhao <i@bugenzhao.com> * add unit test Signed-off-by: Bugen Zhao <i@bugenzhao.com> * add fixme Signed-off-by: Bugen Zhao <i@bugenzhao.com> * add issue Signed-off-by: Bugen Zhao <i@bugenzhao.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Unify the hash implementation into
Scalar::hash_scalar
. Also fix the implementation of thehash_at
function for list and struct array.Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
Hash
implementation onDatum
is not consistent withArray::hash_at
#3457