Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): enable delta lake sink #10374

Merged
merged 2 commits into from
Jun 16, 2023
Merged

feat(sink): enable delta lake sink #10374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f707c3d
feat(sink): enable delta lake sink
wenym1 Jun 16, 2023
3a22ec9
Merge branch 'main' into yiming/delta-lake-sink
wenym1 Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/connector/src/sink/remote.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ use super::catalog::SinkCatalog;
use crate::sink::{record_to_json, Result, Sink, SinkError, TimestampHandlingMode};
use crate::ConnectorParams;

pub const VALID_REMOTE_SINKS: [&str; 3] = ["jdbc", "file", "iceberg"];
pub const VALID_REMOTE_SINKS: [&str; 3] = ["jdbc", "iceberg", "deltalake"];

pub fn is_valid_remote_sink(connector_type: &str) -> bool {
VALID_REMOTE_SINKS.contains(&connector_type)
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/optimizer/plan_node/stream_sink.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ impl StreamSink {
Distribution::Single => RequiredDist::single(),
_ => {
match properties.get("connector") {
Some(s) if s == "iceberg" => {
Some(s) if s == "iceberg" || s == "deltalake" => {
// iceberg with multiple parallelism will fail easily with concurrent commit
// on metadata
// TODO: reset iceberg sink to have multiple parallelism
Expand Down