Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agg): do not gen unexpected agg expression #10434

Merged
merged 2 commits into from
Jun 20, 2023
Merged

fix(agg): do not gen unexpected agg expression #10434

merged 2 commits into from
Jun 20, 2023

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Jun 20, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#10252 (comment)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/fix Bug fix label Jun 20, 2023
@st1page st1page changed the title fix(agg): do not gen unessary agg expression fix(agg): do not gen unexpected agg expression Jun 20, 2023
@xiangjinwu xiangjinwu linked an issue Jun 20, 2023 that may be closed by this pull request
@st1page st1page enabled auto-merge June 20, 2023 07:01
@st1page st1page added this pull request to the merge queue Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #10434 (c85573e) into main (567fa38) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #10434   +/-   ##
=======================================
  Coverage   70.50%   70.50%           
=======================================
  Files        1260     1260           
  Lines      215075   215075           
=======================================
+ Hits       151646   151647    +1     
+ Misses      63429    63428    -1     
Flag Coverage Δ
rust 70.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/agg/mode.rs 2.04% <100.00%> (ø)
src/expr/src/agg/percentile_disc.rs 1.85% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2023
@xiangjinwu xiangjinwu added this pull request to the merge queue Jun 20, 2023
@st1page
Copy link
Contributor Author

st1page commented Jun 20, 2023

It fix the bug which is introduced in this release so remove the "need-cherry-pick-v0.19" tag

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2023
@st1page st1page enabled auto-merge June 20, 2023 11:13
@st1page st1page added this pull request to the merge queue Jun 20, 2023
Merged via the queue into main with commit f0f96a8 Jun 20, 2023
@st1page st1page deleted the sts/fix branch June 20, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: cleanup invalid overloads of mode and percentile_disc
4 participants