Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e tests for read-only transaction in multiple sessions #10902

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

We can now establish multiple connections in sqllogictest-rs after risinglightdb/sqllogictest-rs#180! Thus, it's possible to test that read-only transaction always operates on the same snapshot.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao requested review from chenzl25, fuyufjh and xxchan July 12, 2023 04:34
@github-actions github-actions bot added the component/test Test related issue. label Jul 12, 2023
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao enabled auto-merge July 12, 2023 07:26
@BugenZhao BugenZhao added this pull request to the merge queue Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #10902 (2affa31) into main (9862a67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #10902   +/-   ##
=======================================
  Coverage   69.99%   69.99%           
=======================================
  Files        1307     1307           
  Lines      223116   223116           
=======================================
  Hits       156171   156171           
  Misses      66945    66945           
Flag Coverage Δ
rust 69.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 05d7986 Jul 12, 2023
@BugenZhao BugenZhao deleted the bz/transaction-test branch July 12, 2023 08:14
kwannoel pushed a commit that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants