-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(udf): check the data type returned from UDF server #12202
Conversation
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Codecov Report
@@ Coverage Diff @@
## main #12202 +/- ##
==========================================
- Coverage 69.79% 69.78% -0.02%
==========================================
Files 1408 1408
Lines 235678 235723 +45
==========================================
- Hits 164503 164498 -5
- Misses 71175 71225 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should we add some tests?
- When the error occurs, eval_infallible will call UDF for each row, right? Not sure if it has any problems in this case. I think it’s not a very big deal. 🤔️
Yes. But I couldn't think of a way to test this in sqllogictest. 🤔️
Yes. I'm also not sure about it. I'll be soon working on fixing #11586. At that time I may put the responsibility of |
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #10828
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.