Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector): introduce inline e2e test for CDC table schema change #12344

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Sep 15, 2023

Signed-off-by: Bugen Zhao i@bugenzhao.comI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Introduce "inline" end-to-end test for sources, i.e., one can directly interact with the external services along with RisingWave in a single slt file. Leveraging the new features from sqllogictest-rs:

Add a test for CDC table schema change as an example. Follow up of #12306.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the component/test Test related issue. label Sep 15, 2023
@BugenZhao BugenZhao force-pushed the bz/alter-cdc-table-test-2 branch from fff3561 to c421265 Compare September 18, 2023 13:00
Base automatically changed from bz/alter-cdc-table to main September 19, 2023 06:52
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao force-pushed the bz/alter-cdc-table-test-2 branch from b05b44a to 4f7ea71 Compare September 19, 2023 12:32
@BugenZhao BugenZhao marked this pull request as ready for review September 19, 2023 12:34
@BugenZhao BugenZhao changed the title test: add e2e test for CDC table schema change test: add inline e2e test for CDC table schema change Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #12344 (7c3f6d1) into main (c8ea5ee) will decrease coverage by 0.01%.
Report is 17 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12344      +/-   ##
==========================================
- Coverage   69.68%   69.68%   -0.01%     
==========================================
  Files        1422     1422              
  Lines      235786   235786              
==========================================
- Hits       164310   164305       -5     
- Misses      71476    71481       +5     
Flag Coverage Δ
rust 69.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BugenZhao BugenZhao changed the title test: add inline e2e test for CDC table schema change test: introduce inline e2e test for CDC table schema change Sep 20, 2023
@BugenZhao BugenZhao changed the title test: introduce inline e2e test for CDC table schema change test(connector): introduce inline e2e test for CDC table schema change Sep 20, 2023
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao requested a review from a team as a code owner September 20, 2023 05:58
Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM!

Copy link
Member Author

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangrunji0408 PTAL 🥰

@BugenZhao BugenZhao requested a review from xxchan September 21, 2023 06:32
@BugenZhao BugenZhao added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit a7b7688 Sep 21, 2023
@BugenZhao BugenZhao deleted the bz/alter-cdc-table-test-2 branch September 21, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants