feat(optimizer): refactor table desc && SeqScan && SeqScan pk derive && SeqScan serialize (#1250) #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
reviewed
Mar 25, 2022
| let fields = required_col_idx | ||
| .iter() | ||
| .enumerate() | ||
| .map(|(op_idx, tb_idx)| { |
There was a problem hiding this comment.
Is op_idx the index of the output? Please use a more detailed name.
There was a problem hiding this comment.
Let's ask the original PR author 🤪
…&& SeqScan serialize
skyzh
force-pushed
the
skyzh/refactor_table_desc
branch
from
d8b7e3e to
3a21ce1
Compare
Signed-off-by: Alex Chi <iskyzh@gmail.com>
I will fix them in the another PR, and we will merge this first to not blocking others |
skyzh
changed the title
BugenZhao
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
the
LogicalScanBatchScanStreamScanhas not enough information to serialize to a plan for CN, so add the tableDesc in the LogicalScan.TableDescadd all columnsLogicalSeqScanLogicalValuesinstead ofLogicalSeqScanfor some unit test. BTW, we will use optimizer: add mock plan node just for test #1253 to do the optimizer unit testLogicalSeqScanandStreamScanChecklist
Refer to a related PR or issue link (optional)
Exactly the same as #1250