-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename streaming/group_top_n/main1.slt
to main.slt
#13187
Conversation
Signed-off-by: Richard Chien <stdrc@outlook.com>
streaming/group_top_n/main.slt
to main.slt
streaming/group_top_n/main1.slt
to main.slt
QueryError: Catalog error: database with name main_slt exists" |
Seems the sqllogictest version is not bumped? @xxchan |
Line 45 in 23d2f81
|
Oh, maybe we need to upgrade for sim. It uses lib instead of bin. |
It's using 0.17, weird. |
Submitted a new PR for sqllogictest-rs: risinglightdb/sqllogictest-rs#198 |
Signed-off-by: Richard Chien <stdrc@outlook.com>
f07c4d0
to
80369b1
Compare
Signed-off-by: Richard Chien <stdrc@outlook.com>
Why |
Signed-off-by: Richard Chien <stdrc@outlook.com>
Codecov Report
@@ Coverage Diff @@
## main #13187 +/- ##
==========================================
- Coverage 68.07% 68.01% -0.06%
==========================================
Files 1521 1522 +1
Lines 257858 257904 +46
==========================================
- Hits 175546 175425 -121
- Misses 82312 82479 +167
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously I named it
main1.slt
because of a limitation ofsqllogictest-rs
, now it's fixed (risinglightdb/sqllogictest-rs#194, risinglightdb/sqllogictest-rs#198).Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.