Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scale): fix serving fragment bitmap for scale #13395

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #13395 (53a0547) into main (950ed58) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13395      +/-   ##
==========================================
+ Coverage   67.81%   67.87%   +0.05%     
==========================================
  Files        1526     1526              
  Lines      259803   259843      +40     
==========================================
+ Hits       176197   176372     +175     
+ Misses      83606    83471     -135     
Flag Coverage Δ
rust 67.87% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/meta/src/serving/mod.rs 0.00% <0.00%> (ø)
src/meta/src/stream/scale.rs 10.24% <0.00%> (-0.27%) ⬇️

... and 16 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@shanicky
Copy link
Contributor

for mapping in fragment_mapping_to_notify {

Did the mapping update here (in post_apply_reschedules) not take effect? 🤔

@chenzl25
Copy link
Contributor Author

for mapping in fragment_mapping_to_notify {

Did the mapping update here (in post_apply_reschedules) not take effect? 🤔

IIRC, @zwang28 had introduced a ServingParallelUnitMappings which is different from ParallelUnitMapping (for streaming). We need to notify changed ServingParallelUnitMappings to the frontend as well.

Copy link
Contributor

@zwang28 zwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@chenzl25 chenzl25 added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit 69ed227 Nov 14, 2023
26 of 27 checks passed
@chenzl25 chenzl25 deleted the dylan/fix_scale_serving_bitmap branch November 14, 2023 04:51
@zwang28
Copy link
Contributor

zwang28 commented Nov 16, 2023

FYI you can check serving vnode mapping in risectl. #10331
@chenzl25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants