Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): logical scan pk derive #1340

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Mar 28, 2022

What's changed and what's your intention?

fix bug && add test.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#1333

@st1page st1page requested a review from skyzh March 28, 2022 10:11
@github-actions github-actions bot added the type/fix Bug fix label Mar 28, 2022
skyzh added 2 commits March 28, 2022 18:34
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh enabled auto-merge (squash) March 28, 2022 10:35
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1340 (6cf38be) into main (ee799a4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1340      +/-   ##
============================================
+ Coverage     69.94%   69.97%   +0.02%     
  Complexity     2766     2766              
============================================
  Files          1030     1030              
  Lines         88920    88928       +8     
  Branches       1790     1790              
============================================
+ Hits          62198    62229      +31     
+ Misses        25831    25808      -23     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.92% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/frontend/src/optimizer/plan_node/logical_scan.rs 100.00% <100.00%> (ø)
rust/frontend/test_runner/src/lib.rs 73.20% <100.00%> (+0.65%) ⬆️
rust/connector/src/filesystem/file_common.rs 80.71% <0.00%> (-0.45%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.09% <0.00%> (-0.28%) ⬇️
rust/common/src/types/ordered_float.rs 22.50% <0.00%> (+0.19%) ⬆️
...ntend/src/optimizer/plan_node/stream_table_scan.rs 94.64% <0.00%> (+2.67%) ⬆️
rust/frontend/src/handler/create_mv.rs 97.95% <0.00%> (+44.89%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit 94d5d47 into main Mar 28, 2022
@skyzh skyzh deleted the sts/optimizer_fix_logical_scan_pk branch March 28, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants