Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(optimizer): remove WithXXX on PlanNode #1388

Merged
merged 13 commits into from
Mar 29, 2022

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Mar 29, 2022

What's changed and what's your intention?

remove those "WithXXX" trait

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@st1page st1page requested a review from xxchan March 29, 2022 11:05
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1388 (9cca7cb) into main (965c914) will increase coverage by 0.06%.
The diff coverage is 74.00%.

@@             Coverage Diff              @@
##               main    #1388      +/-   ##
============================================
+ Coverage     70.08%   70.15%   +0.06%     
  Complexity     2766     2766              
============================================
  Files          1030     1027       -3     
  Lines         89482    89492      +10     
  Branches       1790     1790              
============================================
+ Hits          62717    62781      +64     
+ Misses        25874    25820      -54     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 72.12% <74.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/frontend/src/optimizer/mod.rs 93.24% <ø> (ø)
...t/frontend/src/optimizer/plan_node/batch_delete.rs 71.42% <ø> (+5.63%) ⬆️
...frontend/src/optimizer/plan_node/batch_exchange.rs 79.31% <ø> (-1.94%) ⬇️
...t/frontend/src/optimizer/plan_node/batch_filter.rs 82.85% <ø> (-1.36%) ⬇️
...frontend/src/optimizer/plan_node/batch_hash_agg.rs 70.31% <ø> (-1.33%) ⬇️
...rontend/src/optimizer/plan_node/batch_hash_join.rs 91.75% <ø> (-0.25%) ⬇️
...t/frontend/src/optimizer/plan_node/batch_insert.rs 68.42% <ø> (+5.00%) ⬆️
...st/frontend/src/optimizer/plan_node/batch_limit.rs 0.00% <ø> (ø)
.../frontend/src/optimizer/plan_node/batch_project.rs 66.66% <ø> (-1.59%) ⬇️
...frontend/src/optimizer/plan_node/batch_seq_scan.rs 93.18% <ø> (-0.44%) ⬇️
... and 41 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xxchan xxchan changed the title Sts/optimizer refactor plan node refactor(optimizer): refactor plan node Mar 29, 2022
@st1page st1page changed the title refactor(optimizer): refactor plan node refactor(optimizer): remove WithXXX on PlanNode Mar 29, 2022
@st1page st1page enabled auto-merge (squash) March 29, 2022 11:43
@st1page st1page merged commit 930c42f into main Mar 29, 2022
@st1page st1page deleted the sts/optimizer_refactor_plan_node branch March 29, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants