Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): move worker node manager from frontend to batch #15947

Merged

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Mar 27, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@liurenjie1024
Copy link
Contributor

Is this the only solution? It's odd to me that this module belongs to batch.

@chenzl25
Copy link
Contributor Author

Is this the only solution? It's odd to me that this module belongs to batch.

To some extent, yes, because our local queries are executed in GenericExchangeExecutor which belongs to the batch module.

@chenzl25
Copy link
Contributor Author

Is this the only solution? It's odd to me that this module belongs to batch.

To some extent, yes, because our local queries are executed in GenericExchangeExecutor which belongs to the batch module.

See #15951 for mode detail. cc @liurenjie1024

@chenzl25 chenzl25 added this pull request to the merge queue Mar 29, 2024
Merged via the queue into main with commit 2ab5aef Mar 29, 2024
31 of 32 checks passed
@chenzl25 chenzl25 deleted the dylan/move_worker_node_manager_from_frontend_to_batch branch March 29, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants