docs: add readme for docker folder #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
Nebulazhang
approved these changes
Apr 7, 2022
KeXiangWang
reviewed
Apr 7, 2022
|
|
||
| ``` | ||
| make docker_frontend | ||
| make docker_backend |
There was a problem hiding this comment.
I added a frontend-v2 dockerfile for rust frontend. Maybe also modify here and Makefile and add frontend-v2 related commands.
There was a problem hiding this comment.
By the way, meta, compute and frontend can actually share a same binary risingwave. We indeed need only one image for all services.
There was a problem hiding this comment.
Yes. Then it should not be called backend :)
Codecov Report
@@ Coverage Diff @@
## main #1649 +/- ##
=========================================
Coverage 69.80% 69.80%
Complexity 2766 2766
=========================================
Files 1050 1050
Lines 92460 92460
Branches 1790 1790
=========================================
+ Hits 64540 64541 +1
+ Misses 27029 27028 -1
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Alex Chi <iskyzh@gmail.com>
skyzh
force-pushed
the
skyzh/docker-readme
branch
from
a7270b5 to
c0f169b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Chi iskyzh@gmail.com
What's changed and what's your intention?
As title
Checklist
Refer to a related PR or issue link (optional)