-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): allow AnyShard for column indices #1653
Conversation
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Not sure if this is a valid fix, but the truth is |
🤔 So where does the |
That's derived by MaterializeExecutor's input, that is to say, |
Codecov Report
@@ Coverage Diff @@
## main #1653 +/- ##
============================================
- Coverage 69.80% 69.80% -0.01%
Complexity 2766 2766
============================================
Files 1050 1050
Lines 92460 92459 -1
Branches 1790 1790
============================================
- Hits 64542 64538 -4
- Misses 27027 27030 +3
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could get this fixed first
* fix(optimizer): materialize's dist should statisfies pk * more detail * fix ut * revert #1653 * fix * fix
Signed-off-by: Alex Chi iskyzh@gmail.com
What's changed and what's your intention?
As title
Checklist
Refer to a related PR or issue link (optional)
fix #1652