Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): allow AnyShard for column indices #1653

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 7, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

fix #1652

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh requested review from st1page and xx01cyx April 7, 2022 07:38
@skyzh
Copy link
Contributor Author

skyzh commented Apr 7, 2022

Not sure if this is a valid fix, but the truth is AnyShard doesn't get fully eliminated 🤪

@github-actions github-actions bot added the type/fix Bug fix label Apr 7, 2022
@xx01cyx
Copy link
Contributor

xx01cyx commented Apr 7, 2022

🤔 So where does the AnyShard come from? cc @st1page

@skyzh
Copy link
Contributor Author

skyzh commented Apr 7, 2022

🤔 So where does the AnyShard come from? cc @st1page

That's derived by MaterializeExecutor's input, that is to say, StreamProject in the issue.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1653 (2d58688) into main (9c2d6fe) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1653      +/-   ##
============================================
- Coverage     69.80%   69.80%   -0.01%     
  Complexity     2766     2766              
============================================
  Files          1050     1050              
  Lines         92460    92459       -1     
  Branches       1790     1790              
============================================
- Hits          64542    64538       -4     
- Misses        27027    27030       +3     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.62% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/frontend/src/optimizer/property/distribution.rs 85.71% <100.00%> (+1.09%) ⬆️
src/meta/src/manager/stream_clients.rs 88.88% <0.00%> (-7.41%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.13% <0.00%> (-0.28%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@xx01cyx xx01cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could get this fixed first

@skyzh skyzh merged commit 824b7d2 into main Apr 7, 2022
@skyzh skyzh deleted the skyzh/allow-anyshard branch April 7, 2022 07:57
st1page added a commit that referenced this pull request Apr 19, 2022
st1page added a commit that referenced this pull request Apr 19, 2022
* fix(optimizer): materialize's dist should statisfies pk

* more detail

* fix ut

* revert #1653

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(frontend): optimizer crashed on INNER JOIN
2 participants