Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lazily create guarded metrics when first using it #17812

Closed
wants to merge 1 commit into from

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jul 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Only create create a labeled metrics when we use the metrics for the first time. This will be helpful for connector metrics. For example, currently some iceberg sink related metrics are passed to iceberg sink via SinkMetrics struct. However, we will create a label guarded metrics on these iceberg metrics even though the sink is not iceberg sink, which increases unnecessary labeled metrics.

In this PR, we change to initial the metric when we use the metrics for the firstly via LazyLock.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh
Copy link
Member

fuyufjh commented Jul 25, 2024

Hmmm, the complexity is unnecessary to me. For the specific problem I talked with @chenzl25 today, I think the more straight-forward fix is removing the iceberg_xxx metrics from SinkMetrics to something else such as IcebergMetrics, and then let the IcebergSink to maintain it.

@graphite-app graphite-app bot requested a review from a team July 25, 2024 07:35
Copy link
Contributor

This PR has been open for 60 days with no activity.

If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it.

If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the no-pr-activity label.

You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏)
Don't worry if you think the PR is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@fuyufjh
Copy link
Member

fuyufjh commented Sep 25, 2024

I think the more straight-forward fix is removing the iceberg_xxx metrics from SinkMetrics to something else such as IcebergMetrics, and then let the IcebergSink to maintain it.

I'd like to try this when I get idle time. Would be nice if you can help @chenzl25 :lark-cry:

@chenzl25
Copy link
Contributor

I think the more straight-forward fix is removing the iceberg_xxx metrics from SinkMetrics to something else such as IcebergMetrics, and then let the IcebergSink to maintain it.

I'd like to try this when I get idle time. Would be nice if you can help @chenzl25 :lark-cry:

Oh, I remember this issue and tried to extract iceberg metric from the sink metrics before but failed because it would cause a circular dependency 🥵 . A big effort is needed to refactor the sink metrics.

@fuyufjh fuyufjh mentioned this pull request Sep 26, 2024
9 tasks
@fuyufjh fuyufjh closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants