Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog): add views' dependencies in rw_depend #18596

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

KeXiangWang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Reported by users.
Previously, rw_depend doesn't contain dependencies of views, which is misaligned with https://docs.risingwave.com/docs/current/rw_catalog/#available-risingwave-catalogs:~:text=between%20tables%2C%20indexes%2C-,views,-%2C%20materialized%20views%2C%20sources. This PR fixes this issue.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@KeXiangWang KeXiangWang changed the title fix(meta): add views' dependencies in rw_depend fix(catalog): add views' dependencies in rw_depend Sep 18, 2024
Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx for the pr!

@KeXiangWang KeXiangWang added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@KeXiangWang KeXiangWang added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit c7b6fff Sep 19, 2024
30 of 31 checks passed
@KeXiangWang KeXiangWang deleted the wkx/fix-rw-depend-for-view branch September 19, 2024 06:54
@lmatz
Copy link
Contributor

lmatz commented Sep 19, 2024

Looks like the cherry-pick failed...

@arkbriar
Copy link
Contributor

I'll trigger it again to verify the change to the PR cherry-picker. Will close the duplicate PR later.

github-merge-queue bot pushed a commit that referenced this pull request Sep 20, 2024
Co-authored-by: Kexiang Wang <kx.wang@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants