refactor: sink metrics #18730
Merged
refactor: sink metrics #18730
Task list completed / task-list-completed
Started
2024-09-26 08:08:40
ago
0 / 8 tasks completed
8 tasks still to be completed
Details
Required Tasks
Task | Status |
---|---|
Inside SourceMetrics , there is a pair of MetricsVec instead of actual Metrics. |
Incomplete |
Only when it comes to the specific working struct, build the actual Metrics from MetricsVec with particular labels. |
Incomplete |
Refactor SinkMetrics from a set of Metrics to a set of MetricVec |
Incomplete |
Introduce a GLOBAL_SINK_METRICS |
Incomplete |
SinkWriterMetrics for general sink metrics |
Incomplete |
LogWriterMetrics |
Incomplete |
LogReaderMetrics |
Incomplete |
Iceberg sink related metrics are in multiple places. See iceberg/mod.rs for details |
Incomplete |
The metrics labels were a bit messy. I'd like to do a bit refactoring on them in future PR. | Incomplete |
I have written necessary rustdoc comments | Incomplete |
I have added necessary unit tests and integration tests | Incomplete |
I have added test labels as necessary. See details. | Incomplete |
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). | Incomplete |
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). | Incomplete |
All checks passed in ./risedev check (or alias, ./risedev c ) |
Incomplete |
My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) | Incomplete |
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) | Incomplete |
Loading