Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify duplicated alter_*_name methods #18751

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Sep 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan marked this pull request as ready for review September 28, 2024 12:31
@xxchan xxchan force-pushed the 09-27-feat_ban_alter_source_for_shared_source branch from 155fc55 to 6fe0e51 Compare September 28, 2024 15:06
@xxchan xxchan force-pushed the 09-27-refactor_unify_duplicated_alter___name_methods branch from a0080bf to 9dbf61c Compare September 28, 2024 15:06
Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan xxchan force-pushed the 09-27-refactor_unify_duplicated_alter___name_methods branch from 9dbf61c to fe849f7 Compare September 29, 2024 02:25
@xxchan xxchan changed the base branch from 09-27-feat_ban_alter_source_for_shared_source to main September 29, 2024 02:25
@xxchan xxchan requested a review from yezizp2012 September 29, 2024 02:54
@xxchan xxchan added this pull request to the merge queue Sep 29, 2024
Merged via the queue into main with commit 04af708 Sep 29, 2024
28 of 29 checks passed
@xxchan xxchan deleted the 09-27-refactor_unify_duplicated_alter___name_methods branch September 29, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants