-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(batch): support system column _rw_timestamp for tables #19232
Open
chenzl25
wants to merge
27
commits into
main
Choose a base branch
from
dylan/support_rw_timestamp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,721
−2,790
Open
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
cc537c5
support rw timestamp
chenzl25 f3e8dd0
add test and add a rw_timestamp validator
chenzl25 da60d5c
fix test
chenzl25 6b4519f
fmt
chenzl25 a8c256b
fmt
chenzl25 a8432b6
fix delete
chenzl25 c9a23a5
fix tests
chenzl25 deb27db
fix tests
chenzl25 cf18cbd
fix tests
chenzl25 2fb8312
fix test
chenzl25 e85c372
fmt
chenzl25 f095bc7
fix
chenzl25 16b5545
Merge branch 'main' into dylan/support_rw_timestamp
chenzl25 164b431
fix sink into table
chenzl25 f09c9bd
fmt
chenzl25 42451f5
add system column metadata to column desc
chenzl25 920bc01
add docs
chenzl25 6674169
fix test
chenzl25 ea413d5
fix test
chenzl25 778b877
fix
chenzl25 4b105f7
fix
chenzl25 928f52d
fix tests
chenzl25 ae3c30c
fix
chenzl25 c47b2fa
fix
chenzl25 7f11c65
fix tests
chenzl25 fda1ab3
ignore serializing system column
chenzl25 367e16f
resolve conflicts
chenzl25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
statement ok | ||
SET RW_IMPLICIT_FLUSH TO true; | ||
|
||
statement ok | ||
create table t (a int, id int primary key); | ||
|
||
statement ok | ||
create index idx on t(a); | ||
|
||
statement ok | ||
insert into t values (1, 1), (2, 2); | ||
|
||
query ?? rowsort | ||
select ABS(EXTRACT(EPOCH FROM (_rw_timestamp - now()))) < 2, a, id from t; | ||
---- | ||
t 1 1 | ||
t 2 2 | ||
|
||
sleep 3s | ||
|
||
statement ok | ||
update t set a = 11 where id = 1; | ||
|
||
query ?? rowsort | ||
select ABS(EXTRACT(EPOCH FROM (_rw_timestamp - now()))) < 2, a, id from t; | ||
---- | ||
f 2 2 | ||
t 11 1 | ||
|
||
query ?? rowsort | ||
select ABS(EXTRACT(EPOCH FROM (_rw_timestamp - now()))) < 2, a, id from t where id = 1; | ||
---- | ||
t 11 1 | ||
|
||
query ?? rowsort | ||
select ABS(EXTRACT(EPOCH FROM (_rw_timestamp - now()))) < 2, a, id from t where a = 11; | ||
---- | ||
t 11 1 | ||
|
||
statement ok | ||
delete from t; | ||
|
||
statement ok | ||
drop table t; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring this into a separate method like
get_row_with_rw_timestamp
, and calling it here seems more readable.