Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): reorganize code of global barrier manager (part 1) #19334

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Nov 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Reorganize the code of global barrier worker.

In this PR, code are simply moved in one place to another without modifying the logic.

Some visibility is changed to pass the compile.

In later PR, we will further hide some fields to provide better encapsulation.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 5420 files.

Valid Invalid Ignored Fixed
2304 1 3115 0
Click to see the invalid file list
  • src/meta/src/barrier/context/context_impl.rs

src/meta/src/barrier/context/context_impl.rs Show resolved Hide resolved
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robber stamp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…rg-first' into yiming/global-barrier-worker-reorg-first
@wenym1 wenym1 enabled auto-merge November 11, 2024 10:22
@wenym1 wenym1 added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 3c2e81b Nov 11, 2024
31 of 32 checks passed
@wenym1 wenym1 deleted the yiming/global-barrier-worker-reorg-first branch November 11, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants