-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(barrier): add control request to explicitly create partial graph #19383
Conversation
305429d
to
d95e499
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
d95e499
to
f19abec
Compare
f19abec
to
2b1245a
Compare
I suppose this is more of a code quality improvement? Are there any other motivations behind these changes? |
Code quality is one of the concerns. The other motivation is to maintain subscriptions in per partial graph manner instead of globally. The change that explicitly create a partial graph makes such code easier. |
@@ -372,6 +373,8 @@ pub(super) struct PartialGraphManagedBarrierState { | |||
|
|||
prev_barrier_table_ids: Option<(EpochPair, HashSet<TableId>)>, | |||
|
|||
mv_depended_subscriptions: HashMap<TableId, HashSet<u32>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can introduce a type alias for SubscriptionId
. No need to be in this PR.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously, in local barrier manager, we create a new partial graph state when we see a partial graph id that does not previously exist. In this PR, we will change to add a new control stream request to explicitly create new partial graph, and in recovery when we initialize the control stream, we will specify the initial partial graph.
The set of subscriptions is maintained globally in the local barrier manager. In this PR, we will maintain it per partial graph.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.