Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(barrier): add control request to explicitly create partial graph #19383

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Nov 13, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously, in local barrier manager, we create a new partial graph state when we see a partial graph id that does not previously exist. In this PR, we will change to add a new control stream request to explicitly create new partial graph, and in recovery when we initialize the control stream, we will specify the initial partial graph.

The set of subscriptions is maintained globally in the local barrier manager. In this PR, we will maintain it per partial graph.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@graphite-app graphite-app bot requested a review from a team November 14, 2024 08:48
@wenym1 wenym1 force-pushed the yiming/explicit-create-partial-graph branch from d95e499 to f19abec Compare November 14, 2024 08:50
@wenym1 wenym1 changed the base branch from main to rc/fix-udf-ci November 14, 2024 08:50
Base automatically changed from rc/fix-udf-ci to main November 14, 2024 08:59
@wenym1 wenym1 force-pushed the yiming/explicit-create-partial-graph branch from f19abec to 2b1245a Compare November 14, 2024 09:01
@kwannoel
Copy link
Contributor

kwannoel commented Nov 14, 2024

Previously, in local barrier manager, we create a new partial graph state when we see a partial graph id that does not previously exist. In this PR, we will change to add a new control stream request to explicitly create new partial graph, and in recovery when we initialize the control stream, we will specify the initial partial graph.

I suppose this is more of a code quality improvement? Are there any other motivations behind these changes?

@wenym1
Copy link
Contributor Author

wenym1 commented Nov 14, 2024

Previously, in local barrier manager, we create a new partial graph state when we see a partial graph id that does not previously exist. In this PR, we will change to add a new control stream request to explicitly create new partial graph, and in recovery when we initialize the control stream, we will specify the initial partial graph.

I suppose this is more of a code quality improvement? Are there any other motivations behind these changes?

Code quality is one of the concerns. The other motivation is to maintain subscriptions in per partial graph manner instead of globally. The change that explicitly create a partial graph makes such code easier.

@@ -372,6 +373,8 @@ pub(super) struct PartialGraphManagedBarrierState {

prev_barrier_table_ids: Option<(EpochPair, HashSet<TableId>)>,

mv_depended_subscriptions: HashMap<TableId, HashSet<u32>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can introduce a type alias for SubscriptionId. No need to be in this PR.

@wenym1 wenym1 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit c920694 Nov 14, 2024
36 of 38 checks passed
@wenym1 wenym1 deleted the yiming/explicit-create-partial-graph branch November 14, 2024 11:23
fuyufjh added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants