Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pgwire): support 1-dimension array in extended mode #19432

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Nov 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Related #7949

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh fuyufjh changed the title feat(pgwire): support 1-dimension array feat(pgwire): support 1-dimension array in extended mode Nov 18, 2024
@graphite-app graphite-app bot requested a review from a team November 18, 2024 11:21
@graphite-app graphite-app bot requested a review from a team November 19, 2024 02:19
Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core functionality LGTM.

Adding some notes for other reviewers who are not as familiar with PG coding conventions (like myself), so it's easier for them to review it.

The core functionality is specifically in these lines:
https://github.com/postgres/postgres/blob/c1c09007e219ae68d1f8428a54baf68ccc1f8683/src/backend/utils/adt/arrayfuncs.c#L1606-L1644.

Some things to take note of:

			pq_sendint32(&buf, VARSIZE(outputbytes) - VARHDRSZ);

Here this just gets the length of outputbytes. VARSIZE gets the size of varlena. VARHDRSZ is the header len of varlena. Subtracting them gives us the data len.

AARR_DIMS gives us the dimension of each array (i.e. the len).
AARR_LBOUND gives us the starting offset for each array.

refine text

Co-authored-by: Noel Kwan <47273164+kwannoel@users.noreply.github.com>
@fuyufjh fuyufjh enabled auto-merge November 19, 2024 06:21
@fuyufjh fuyufjh added this pull request to the merge queue Nov 19, 2024
@fuyufjh fuyufjh removed this pull request from the merge queue due to a manual request Nov 19, 2024
@fuyufjh fuyufjh enabled auto-merge November 19, 2024 08:18
@fuyufjh fuyufjh added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit e26292b Nov 19, 2024
28 of 29 checks passed
@fuyufjh fuyufjh deleted the eric/pgwire_support_1dim_list_binary branch November 19, 2024 09:38
buf.put_i32(1); // Has nulls?
buf.put_i32(element_ty.to_oid()); // Element type
buf.put_i32(self.len() as i32); // Length of 1st dimension
buf.put_i32(0); // Offset of 1st dimension
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL array starts at 1 rather than 0.

test=# select array_send(array[2, 3, null]);
                                     array_send                                     
------------------------------------------------------------------------------------
 \x000000010000000100000017000000030000000100000004000000020000000400000003ffffffff
(1 row)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants