feat(snapshot-backfill): introduce state to snapshot backfill #19720
+710
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
wenym1
force-pushed
the
yiming/storage-table-iter-avoid-slice-clone
branch
from
641fa65 to
a3f0881
Compare
wenym1
force-pushed
the
yiming/snapshot-backfill-progress-state
branch
from
c2868dd to
d5c4a10
Compare
Base automatically changed from
yiming/storage-table-iter-avoid-slice-clone
to
main
December 11, 2024 03:46
wenym1
force-pushed
the
yiming/snapshot-backfill-progress-state
branch
from
d5c4a10 to
5567d22
Compare
wenym1
force-pushed
the
yiming/snapshot-backfill-progress-state
branch
from
5567d22 to
ba717b7
Compare
hzxa21
reviewed
Dec 13, 2024
| if self.streams.is_empty() { | ||
| break Poll::Ready(Ok(None)); | ||
| } | ||
| for (vnode, stream) in &mut self.streams { |
There was a problem hiding this comment.
Will polling the streams in vnode order cause starvation or data skew in downstream? Should we use FuturesUnordered instead?
Comment on lines
+245
to
+247
| let uncommitted = backfill_state.uncommitted_state(); | ||
| // TODO: apply to progress state table | ||
| drop(uncommitted); |
There was a problem hiding this comment.
Can you explain why we need to get the reference of the uncommitted state and drop it immediately?
| @@ -105,6 +117,8 @@ impl<S: StateStore> SnapshotBackfillExecutor<S> { | |||
| let first_recv_barrier = receive_next_barrier(&mut self.barrier_rx).await?; | |||
| debug!(epoch = ?first_recv_barrier.epoch, "get first inject barrier"); | |||
| let should_backfill = first_barrier.epoch != first_recv_barrier.epoch; | |||
| let mut backfill_state = | |||
There was a problem hiding this comment.
I don't see we persist the state. Will it be done in a separated PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.